Heritrix
  1. Heritrix
  2. HER-1993

Clean up HTML in web interface

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: Heritrix 3.1.1
    • Fix Version/s: Heritrix 3.1.1
    • Component/s: None
    • Labels:
      None

      Description

      some resource classes generate broken HTML: no HTML/BODY element, unclosed H2 etc. while most are non-problem, one in BeanBrowseResource exhibits broken layout. I'm submitting a fix for it, along with other cleanups. This should make web interface a bit tidy until HER-1726 comes along.

        Activity

        Kenji Nagahashi created issue -
        Hide
        Kenji Nagahashi added a comment -

        pushed changes to html-cleanup branch. please let me know if you see any problems with it.

        Show
        Kenji Nagahashi added a comment - pushed changes to html-cleanup branch . please let me know if you see any problems with it.
        Hide
        Noah Levitt added a comment -

        Did some more cleanup (kinda time-consuming) and pushed to origin/master.
        https://github.com/internetarchive/heritrix3/commit/f7505e6673d0ccfc7a530dd469beded3d701c11f

        Show
        Noah Levitt added a comment - Did some more cleanup (kinda time-consuming) and pushed to origin/master. https://github.com/internetarchive/heritrix3/commit/f7505e6673d0ccfc7a530dd469beded3d701c11f
        Noah Levitt made changes -
        Field Original Value New Value
        Resolution Fixed [ 1 ]
        Assignee Kenji Nagahashi [ kenji ] Noah Levitt [ nlevitt ]
        Status Open [ 1 ] Resolved [ 5 ]
        Hide
        Kenji Nagahashi added a comment -

        After this change, cxml edit textarea is only a few lines high. Apparently <!DOCTYPE html> makes hight:97% style ineffective (it works again when I remove DOCTYPE). Probably HTML4 vs HTML5 difference.

        Show
        Kenji Nagahashi added a comment - After this change, cxml edit textarea is only a few lines high. Apparently <!DOCTYPE html> makes hight:97% style ineffective (it works again when I remove DOCTYPE). Probably HTML4 vs HTML5 difference.
        Hide
        Gordon Mohr added a comment -

        I was bitten by the short TEXTAREA in some but not all browsers. This sort of consume-the-rest-of-the-visible-area layout still seems to require TABLEs in some cases.

        Show
        Gordon Mohr added a comment - I was bitten by the short TEXTAREA in some but not all browsers. This sort of consume-the-rest-of-the-visible-area layout still seems to require TABLEs in some cases.
        Hide
        Noah Levitt added a comment -

        Even since https://github.com/internetarchive/heritrix3/commit/9626b8454a594276728243a77ee85d4a7014a1b1 ? Absolute positioning works afaik. Only problem is it doesn't mix with normal positioning, which is why I had to move the button and stuff below the textarea.

        Show
        Noah Levitt added a comment - Even since https://github.com/internetarchive/heritrix3/commit/9626b8454a594276728243a77ee85d4a7014a1b1 ? Absolute positioning works afaik. Only problem is it doesn't mix with normal positioning, which is why I had to move the button and stuff below the textarea.
        Hide
        Gordon Mohr added a comment -

        I'd seen the problem before that commit. No problem now... but regarding the EditRepresentation changs:

        • if gray makes sense as a background here, maybe it should be the default everywhere? (Seems strange to do in only one place.)
        • do you prefer the submit-changes and confirm-messaging at bottom? because I think a table approach could put it back to the top with desired textarea sizing.

        (Related: I'm going to bring in Alex Osborne's syntax-highlighting contribution: HER-2001. Pretty and helpful in highlighting syntax errors while typing.)

        Show
        Gordon Mohr added a comment - I'd seen the problem before that commit. No problem now... but regarding the EditRepresentation changs: • if gray makes sense as a background here, maybe it should be the default everywhere? (Seems strange to do in only one place.) • do you prefer the submit-changes and confirm-messaging at bottom? because I think a table approach could put it back to the top with desired textarea sizing. (Related: I'm going to bring in Alex Osborne's syntax-highlighting contribution: HER-2001 . Pretty and helpful in highlighting syntax errors while typing.)

          People

          • Assignee:
            Noah Levitt
            Reporter:
            Kenji Nagahashi
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: